Fix wayland capture on nvidia for kms #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Your PR was set to |
|
I confirm this works great and I can stream from Wayland now. The performance of KMS + Wayland is a bit disappointing compared to x11+nvfbc. I can only reach ~85fps instead of 120fps even though the encoder isn't working very hard and mouse/keyboard are very laggy. It's probably just nvidia's fault. |
|
+1 Streaming now actually works on wayland + nvidia without any issues. I don't go over 60FPS so I can't vouch for the performance of higher FPS but that's probably due to KMS and not due to this patch |
kelvie
added a commit
to kelvie/Sunshine
that referenced
this pull request
Jan 24, 2024
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#649, in PR LizardByte#884.
11 tasks
kelvie
added a commit
to kelvie/Sunshine
that referenced
this pull request
Jan 25, 2024
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
kelvie
added a commit
to kelvie/Sunshine
that referenced
this pull request
Jan 26, 2024
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Jun 6, 2024
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
e-dong
pushed a commit
to e-dong/Sunshine
that referenced
this pull request
Jul 26, 2024
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #649, I added the same code for
kmsgrubwhich from my testing works pretty wellIssues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.